Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visitors): Make sure we disconnect vnodes before leaving rooms. #1170

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

damencho
Copy link
Member

Use case is a single main participant and a visitor node. If jicofo leaves visitor room before disconnecting, the client will reload seeing jicofo leaving. If we disconnect first, we destroy the room with an appropriate message shown to visitors.

damencho and others added 2 commits September 18, 2024 17:04
Use case is a single main participant and a visitor node. If jicofo leaves visitor room before disconnecting, the client will reload seeing jicofo leaving. If we disconnect first, we destroy the room with an appropriate message shown to visitors.
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.56%. Comparing base (ac6cb05) to head (b6ee464).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 76.92% 3 Missing ⚠️
...in/kotlin/org/jitsi/jicofo/xmpp/VisitorsManager.kt 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1170      +/-   ##
============================================
- Coverage     29.24%   27.56%   -1.69%     
+ Complexity      485      476       -9     
============================================
  Files           130      129       -1     
  Lines          7915     7967      +52     
  Branches       1087     1105      +18     
============================================
- Hits           2315     2196     -119     
- Misses         5326     5488     +162     
- Partials        274      283       +9     
Files with missing lines Coverage Δ
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 41.41% <76.92%> (-3.00%) ⬇️
...in/kotlin/org/jitsi/jicofo/xmpp/VisitorsManager.kt 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1effdfd...b6ee464. Read the comment docs.

@bgrozev bgrozev merged commit 52ba365 into master Sep 20, 2024
4 of 5 checks passed
@bgrozev bgrozev deleted the vnode-disconnect branch September 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants