Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the metrics update logic to jicoco. #1134

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Feb 1, 2024

No description provided.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e20abda) 28.57% compared to head (e8fb70d) 28.95%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1134      +/-   ##
============================================
+ Coverage     28.57%   28.95%   +0.38%     
- Complexity      463      470       +7     
============================================
  Files           128      128              
  Lines          7742     7711      -31     
  Branches       1058     1056       -2     
============================================
+ Hits           2212     2233      +21     
+ Misses         5263     5210      -53     
- Partials        267      268       +1     
Files Coverage Δ
...n/kotlin/org/jitsi/jicofo/bridge/BridgeSelector.kt 61.24% <100.00%> (ø)
...rc/main/java/org/jitsi/jicofo/rest/Statistics.java 0.00% <0.00%> (ø)
...o/src/main/kotlin/org/jitsi/jicofo/FocusManager.kt 48.35% <0.00%> (+6.04%) ⬆️
.../main/kotlin/org/jitsi/jicofo/xmpp/XmppServices.kt 0.00% <0.00%> (ø)
...org/jitsi/jicofo/metrics/JicofoMetricsContainer.kt 0.00% <0.00%> (ø)
...src/main/kotlin/org/jitsi/jicofo/JicofoServices.kt 3.75% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e20abda...e8fb70d. Read the comment docs.

@bgrozev bgrozev merged commit be8a115 into jitsi:master Feb 20, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants