Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not leave the conference soon after a conference-request. #1119

Closed
wants to merge 1 commit into from

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Oct 27, 2023

Fixes a race condition in which the conference was stopped while a
client was in the process of joining.

Fixes a race condition in which the conference was stopped while a
client was in the process of joining.
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1119 (d95d74b) into master (067e575) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1119      +/-   ##
============================================
+ Coverage     27.86%   27.88%   +0.01%     
- Complexity      473      474       +1     
============================================
  Files           128      128              
  Lines          7783     7792       +9     
  Branches       1064     1066       +2     
============================================
+ Hits           2169     2173       +4     
- Misses         5342     5346       +4     
- Partials        272      273       +1     
Files Coverage Δ
...otlin/org/jitsi/jicofo/xmpp/ConferenceIqHandler.kt 53.53% <100.00%> (+0.47%) ⬆️
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 44.65% <55.55%> (-0.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067e575...d95d74b. Read the comment docs.

@bgrozev
Copy link
Member Author

bgrozev commented Oct 31, 2023

Jicofo needs to leave the room when the last occupant leaves, otherwise "end conference" can not be enforced. We'll address the issue with a client reload instead

@bgrozev bgrozev closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants