Relax the restart request limits (#1106)

* Make restart request rate limits configurable.

* Relax restart request rate limits.

jicofo-selector/src/main/resources/reference.conf

@@ -246,6 +246,15 @@ jicofo {
     //
     // Note: this feature is indented to be removed once older clients (mobile) are phased out.
     enable-multi-stream-backward-compat = false
+
+    // Rate limits for a participant requesting an ICE restart.
+    restart-request-rate-limits {
+        // Never accept a request unless at least `min-interval` has passed since the last request
+        min-interval = 5 seconds
+        // Accept at most `max-requests` per `interval`
+        max-requests = 5
+        interval = 1 minute
+    }
   }
 
   // Configuration for the internal health checks performed by jicofo.

jicofo/src/main/kotlin/org/jitsi/jicofo/ConferenceConfig.kt

@@ -84,6 +84,18 @@ class ConferenceConfig private constructor() {
             }
     }
 
+    val restartRequestMinInterval: Duration by config {
+        "jicofo.conference.restart-request-rate-limits.min-interval".from(newConfig)
+    }
+
+    val restartRequestMaxRequests: Int by config {
+        "jicofo.conference.restart-request-rate-limits.max-requests".from(newConfig)
+    }
+
+    val restartRequestInterval: Duration by config {
+        "jicofo.conference.restart-request-rate-limits.interval".from(newConfig)
+    }
+
     /**
      * Get the number of milliseconds to delay signaling of Jingle sources given a certain [conferenceSize].
      */

jicofo/src/main/kotlin/org/jitsi/jicofo/conference/Participant.kt

@@ -107,7 +107,12 @@ open class Participant @JvmOverloads constructor(
      */
     private var inviteRunnable: Cancelable? = null
 
-    private val restartRequestsRateLimit = RateLimit(clock = clock)
+    private val restartRequestsRateLimit = RateLimit(
+        minInterval = ConferenceConfig.config.restartRequestMinInterval,
+        maxRequests = ConferenceConfig.config.restartRequestMaxRequests,
+        interval = ConferenceConfig.config.restartRequestInterval,
+        clock = clock
+    )
 
     /**
      * The Jingle session (if any) established with this peer.