-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] TalkRoom 조회 Query 리펙토링 #63
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,9 @@ | |
import com.jisungin.domain.talkroom.TalkRoomRole; | ||
import com.jisungin.domain.talkroom.repository.TalkRoomRepository; | ||
import com.jisungin.domain.talkroom.repository.TalkRoomRoleRepository; | ||
import com.jisungin.domain.talkroomimage.TalkRoomImage; | ||
import com.jisungin.domain.talkroomimage.repository.TalkRoomImageRepository; | ||
import com.jisungin.domain.talkroomlike.repository.TalkRoomLikeRepository; | ||
import com.jisungin.domain.user.User; | ||
import com.jisungin.domain.user.repository.UserRepository; | ||
import com.jisungin.exception.BusinessException; | ||
|
@@ -35,6 +38,8 @@ public class TalkRoomService { | |
private final BookRepository bookRepository; | ||
private final UserRepository userRepository; | ||
private final CommentRepository commentRepository; | ||
private final TalkRoomImageRepository talkRoomImageRepository; | ||
private final TalkRoomLikeRepository talkRoomLikeRepository; | ||
|
||
@Transactional | ||
public TalkRoomResponse createTalkRoom(TalkRoomCreateServiceRequest request, AuthContext authContext) { | ||
|
@@ -51,20 +56,49 @@ public TalkRoomResponse createTalkRoom(TalkRoomCreateServiceRequest request, Aut | |
|
||
readingStatus.stream().map(status -> TalkRoomRole.roleCreate(talkRoom, status)) | ||
.forEach(talkRoomRoleRepository::save); | ||
|
||
return TalkRoomResponse.of(user.getName(), talkRoom.getTitle(), talkRoom.getContent(), readingStatus, | ||
|
||
TalkRoomResponse response = TalkRoomResponse.of(user.getName(), talkRoom.getTitle(), | ||
talkRoom.getContent(), readingStatus, | ||
book.getImageUrl(), book.getTitle()); | ||
|
||
if (request.getImageUrls() != null && !request.getImageUrls().isEmpty()) { | ||
request.getImageUrls().stream() | ||
.map(url -> TalkRoomImage.createImages(talkRoom, url)) | ||
.forEach(talkRoomImageRepository::save); | ||
|
||
List<String> imageUrls = talkRoomImageRepository.findByTalkRoomIdWithImageUrl( | ||
talkRoom.getId()); | ||
|
||
response.addTalkRoomImages(imageUrls); | ||
} | ||
|
||
return response; | ||
} | ||
|
||
public PageResponse<TalkRoomFindAllResponse> findAllTalkRoom(SearchServiceRequest search) { | ||
return talkRoomRepository.findAllTalkRoom(search); | ||
public PageResponse<TalkRoomFindAllResponse> findAllTalkRoom(SearchServiceRequest search, AuthContext authContext) { | ||
PageResponse<TalkRoomFindAllResponse> response = talkRoomRepository.findAllTalkRoom(search.getOffset(), | ||
search.getSize(), search.getOrder(), | ||
search.getQuery()); | ||
|
||
if (authContext.getUserId() != null) { | ||
List<Long> talkRoomIds = talkRoomLikeRepository.userLikeTalkRooms(authContext.getUserId()); | ||
response.addContents(talkRoomIds); | ||
} | ||
|
||
return response; | ||
} | ||
|
||
public TalkRoomFindOneResponse findOneTalkRoom(Long talkRoomId) { | ||
public TalkRoomFindOneResponse findOneTalkRoom(Long talkRoomId, AuthContext authContext) { | ||
TalkRoom talkRoom = talkRoomRepository.findById(talkRoomId) | ||
.orElseThrow(() -> new BusinessException(ErrorCode.TALK_ROOM_NOT_FOUND)); | ||
|
||
return talkRoomRepository.findOneTalkRoom(talkRoom.getId()); | ||
TalkRoomFindOneResponse response = talkRoomRepository.findOneTalkRoom(talkRoom.getId()); | ||
|
||
if (authContext.getUserId() != null) { | ||
Long likeTalkRoom = talkRoomLikeRepository.userLikeTalkRoom(talkRoomId, authContext.getUserId()); | ||
response.addTalkRoomLikeId(likeTalkRoom); | ||
} | ||
return response; | ||
} | ||
|
||
@Transactional | ||
|
@@ -87,8 +121,24 @@ public TalkRoomResponse editTalkRoom(TalkRoomEditServiceRequest request, AuthCon | |
readingStatus.stream().map(status -> TalkRoomRole.roleCreate(talkRoom, status)) | ||
.forEach(talkRoomRoleRepository::save); | ||
|
||
return TalkRoomResponse.of(user.getName(), talkRoom.getTitle(), talkRoom.getContent(), readingStatus, | ||
if (request.getNewImage() != null && !request.getNewImage().isEmpty()) { | ||
request.getNewImage().stream().map(url -> TalkRoomImage.createImages(talkRoom, url)) | ||
.forEach(talkRoomImageRepository::save); | ||
} | ||
|
||
if (request.getRemoveImage() != null && !request.getRemoveImage().isEmpty()) { | ||
request.getRemoveImage().stream().map(s -> talkRoomImageRepository.findByTalkRoomAndImageUrl(talkRoom, s)) | ||
.forEach(talkRoomImageRepository::deleteAll); | ||
} | ||
Comment on lines
+124
to
+132
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 해당 if문이 어떤 동작을 하는지 간단하게 설명 부탁드립니다 ! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 유저가 토론방을 수정할 때, 새로운 이미지를 추가하고 기존에 있던 이미지를 삭제 할때 if문으로 새로운 이미지 혹은 삭제된 이미지 url이 있는지 체크를 하고 있다면 로직을 수행하도록 했습니다! |
||
|
||
TalkRoomResponse response = TalkRoomResponse.of(user.getName(), talkRoom.getTitle(), | ||
talkRoom.getContent(), readingStatus, | ||
talkRoom.getBook().getImageUrl(), talkRoom.getBook().getTitle()); | ||
|
||
List<String> images = talkRoomImageRepository.findByTalkRoomIdWithImageUrl(talkRoom.getId()); | ||
response.addTalkRoomImages(images); | ||
|
||
return response; | ||
} | ||
|
||
@Transactional | ||
|
@@ -105,6 +155,10 @@ public void deleteTalkRoom(Long talkRoomId, AuthContext authContext) { | |
|
||
commentRepository.findByTalkRoom(talkRoom).ifPresent(commentRepository::delete); | ||
|
||
List<TalkRoomImage> images = talkRoomImageRepository.findByTalkRoom(talkRoom); | ||
if (images != null) { | ||
talkRoomImageRepository.deleteAll(images); | ||
} | ||
talkRoomRoleRepository.deleteAllByTalkRoom(talkRoom); | ||
talkRoomRepository.delete(talkRoom); | ||
} | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 정렬 기준에서 "re"를 사용하시는 지 궁금해서 리뷰 남깁니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정렬 값이 null이 들어올 시 seach.getOrder() 로 가져오게 되면 예외가 발생하기 때문에 null이면 기본으로 최신순으로 정렬하게 하기 위해 짧게 "re" 값으로 넘겨줬습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"re" 값이 불명확한거 같아서 디폴드 값이 무조건 최신순이라면 default나 recent로 값을 넘겨주어도 되지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 수정하도록 하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 알겠습니다!