[Feature] 책 리뷰 추가, 삭제 API 구현 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
pdohyung
force-pushed
the
feature/31-book-review-api
branch
from
51e2854
to
760f3c7
Compare
jwooo
requested changes
Mar 26, 2024
Comment on lines
59
to
62
| public boolean isSame(Long userId) { | ||
| return this.id.equals(userId); | ||
| } | ||
|
|
There was a problem hiding this comment.
isSame과 같은 기능을 하는 isMe 메서드가 위쪽에 하나 있어 둘 중에 하나만 사용하면 좋을 것 같습니다!
There was a problem hiding this comment.
정우님 말에 공감합니다. 똑같은 메서드가 두 번 반복되네요
Comment on lines
+35
to
+37
| Review savedReview = reviewRepository.save(Review.create( | ||
| user, book, request.getContent(), request.getRating() | ||
| )); |
There was a problem hiding this comment.
객체간 의존성을 줄이기 위해 request의 값을 꺼내어 String 값을 넘겨주는 건가요?
There was a problem hiding this comment.
넵 맞습니다 ~ 의존성 문제도 있지만 create는 Review의 생성 함수입니다.
Review 도메인은 퍼시스턴스 계층이기 때문에 만약 request를 넘겨준다면 해당 계층이 비즈니스 계층의 내용을 알게 됩니다.
그래서 해당 코드와 같이 값을 뽑아서 전달했습니다 !
AHNYUNKI
approved these changes
Mar 26, 2024
Comment on lines
59
to
62
| public boolean isSame(Long userId) { | ||
| return this.id.equals(userId); | ||
| } | ||
|
|
There was a problem hiding this comment.
정우님 말에 공감합니다. 똑같은 메서드가 두 번 반복되네요
jwooo
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #31
📝 작업 내용
💬 리뷰 요구 사항
특별한 사항은 없습니다 !
리뷰 잘 부탁드립니다.