[Feature] TalkRoom 삭제 API 구현 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jwooo
requested changes
Mar 25, 2024
Comment on lines
106
to
107
| Optional<Comment> comment = commentRepository.findByTalkRoom(talkRoom); | ||
| comment.ifPresent(commentRepository::delete); |
There was a problem hiding this comment.
위 코드는 아래와 같이도 작성할 수 있습니다!!
Optional<Comment> comment = commentRepository.findByTalkRoom(talkRoom)
.ifPresent(commentRepository::delete);There was a problem hiding this comment.
오 그렇군요~
수정 후 다시 코드 올리도록 하겠습니다!
jwooo
approved these changes
Mar 25, 2024
| @@ -103,8 +101,7 @@ public void deleteTalkRoom(Long talkRoomId, Long userId) { | |||
| throw new BusinessException(ErrorCode.UNAUTHORIZED_REQUEST); | |||
| } | |||
|
|
|||
| Optional<Comment> comment = commentRepository.findByTalkRoom(talkRoom); | |||
| comment.ifPresent(commentRepository::delete); | |||
| commentRepository.findByTalkRoom(talkRoom).ifPresent(commentRepository::delete); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #36
📝 작업 내용
💬 리뷰 요구 사항
TalkRoom_ID와Auth정보를 받아온다.TalkRoom_ID를 바탕으로 해당TalkRoom을 조회 후TalkRoom을 생성한User_ID와Auth_ID비교 후 일치하면TalkRoom을 삭제한다.