Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] TalkRoom API 테스트 수정 #32

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

AHNYUNKI
Copy link
Member

@AHNYUNKI AHNYUNKI commented Mar 24, 2024

💡 연관된 이슈

close #29

📝 작업 내용

  • API 변경으로 인한 테스트 수정
  • API 테스트 통합 클래스 생성

💬 리뷰 요구 사항

추상클래스 테스트 통합 클래스 적용했습니다!
제 코드 참고하시고 적용하시면 됩니다.

@AHNYUNKI AHNYUNKI linked an issue Mar 24, 2024 that may be closed by this pull request
2 tasks
@AHNYUNKI AHNYUNKI requested review from pdohyung and jwooo March 24, 2024 14:50
@AHNYUNKI AHNYUNKI self-assigned this Mar 24, 2024
@AHNYUNKI AHNYUNKI added the ✅ Test 테스트 관련 label Mar 24, 2024
Copy link
Member

@pdohyung pdohyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

궁금한 부분 의견 남겼으니 답변 주시고 머지 하시면 될 듯합니다.
수고하셨습니다 👍

Copy link
Collaborator

@jwooo jwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다.

추가적으로 궁금한점 있어 리뷰 남겼습니다. 확인 부탁드립니다!!

Comment on lines +14 to +17
@WebMvcTest(controllers = {
TalkRoomController.class,
CommentController.class
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가되는 컨트롤러 테스트는 해당 위치에 추가하면 되는 건가요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네네!
맞습니다!!

@AHNYUNKI AHNYUNKI merged commit e120dee into develop Mar 25, 2024
1 check passed
@AHNYUNKI AHNYUNKI deleted the talkroom/29-talkRoom-test-api branch March 25, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Test 테스트 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] TalkRoom API 테스트 수정
3 participants