[Feature] 도서와 관련된 리뷰 조회 API 구현 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pdohyung
approved these changes
May 25, 2024
Comment on lines
+31
to
+55
| public void applyJoinStrategy(JPAQuery<?> query) { | ||
| joinRatingStrategy.accept(query); | ||
| applyCommonJoinConditions(query); | ||
| } | ||
|
|
||
| public static ReviewOrderType fromString(String name) { | ||
| try { | ||
| return ReviewOrderType.valueOf(name.toUpperCase()); | ||
| } catch (IllegalArgumentException | NullPointerException e) { | ||
| return ReviewOrderType.LIKE; | ||
| } | ||
| } | ||
|
|
||
| private static void joinRating(JPAQuery<?> query) { | ||
| query.join(rating1); | ||
| } | ||
|
|
||
| private static void leftJoinRating(JPAQuery<?> query) { | ||
| query.leftJoin(rating1); | ||
| } | ||
|
|
||
| private static void applyCommonJoinConditions(JPAQuery<?> query) { | ||
| query.on(review.user.eq(rating1.user) | ||
| .and(review.book.eq(rating1.book))); | ||
| } |
There was a problem hiding this comment.
쿼리의 조인 전략을 enum 클래스에 분리하신 이유가 궁금합니다 !
There was a problem hiding this comment.
해당 쿼리는 orderType에 의해 조인 전략이 변경됩니다. 그렇기 때문에 조인을 추가하는 것은 orderType에 책임이 있다고 생각하여 해당 ENUM에서 추가하는 것으로 분리하였습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #90
📝 작업 내용
이번 PR에서 작업한 내용을 간략히 설명해주세요.
💬 리뷰 요구 사항