Add guest-agent socket; make use of it to request guest shutdown along with ACPI request #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g with ACPI request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see there is already two pull requests implementing shutdown using QEMU guest-agent. Let's not stop there and add third one!
Added guest-agent as suggested in https://wiki.qemu.org/Features/GuestAgent; added start checks and stop cleanups for it similar to monitor socket and a function to send into it.
QEMU GA socket can be moved using conf.d; disabling it is however not an option. QGA socket is always there as is monitor socket, and the virtio device is exposed to a guest. It does not harm and the guest is not obliged to use it if it doesn't want.