Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpcio to v1.64 to fix build error #6170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adlrwbr
Copy link

@adlrwbr adlrwbr commented May 25, 2024

Goals:

Hi, the latest version of jina installed via poetry fails due to its dependency, grpcio v1.57.0, failing to build on x86_64 Linux w/ Python v3.12.3. A Google search brought me to google/bumble#459, which hinted that the solution might be to upgrade to v1.64.0. Sure enough, changing the dependency version fixes the build.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.30%. Comparing base (e3ea29f) to head (df06a19).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6170      +/-   ##
==========================================
- Coverage   54.92%   54.30%   -0.63%     
==========================================
  Files         150      150              
  Lines       14125    14125              
==========================================
- Hits         7758     7670      -88     
- Misses       6367     6455      +88     
Flag Coverage Δ
jina 54.30% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM
Copy link
Member

JoanFM commented Jul 10, 2024

We have seen errors in tests for newer versions of grpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants