Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update file-type to disable eval dynamic code errors during build #1362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rxliuli
Copy link

@rxliuli rxliuli commented Nov 21, 2024

What's Changing and Why

close #1361

What else might be affected

Since I am not familiar with how to build bundles based on the conditions esm/cjs using tshy, I decided to use tsup to complete it after a brief check. A simple check showed that tshy does not seem to support the conditional branching feature of imports in package.json, for example,

{
  "imports": {
    "#file-type/core": {
      "import": "./src/polyfills/esm.ts",
      "require": "./src/polyfills/cjs.ts"
    }
  },
}
image

If someone knows how to use tshy, I am willing to update this PR.

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Update file-type to the latest version to avoid build errors caused by using eval in the old version.
1 participant