Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More info on user's favorites #290

Merged
merged 4 commits into from
Sep 6, 2020

Conversation

N0D4N
Copy link
Contributor

@N0D4N N0D4N commented Jun 14, 2020

Change is for Jikan v3.
Add missing info for user's favorites, that is written in #287, when requesting for user's profile.
Compare responses when requesting to /user/0EedgYy:

  • favorite anime comparison before and after changing
{
"mal_id": 17074,
"url": "https://myanimelist.net/anime/17074/Monogatari_Series__Second_Season",
"image_url": "https://cdn.myanimelist.net/images/anime/3/52133.jpg?s=eae1aba9fc65851acad0b750c9818b40",
"name": "Monogatari Series: Second Season"
}
 {
"mal_id": 17074,
"url": "https://myanimelist.net/anime/17074/Monogatari_Series__Second_Season",
"image_url": "https://cdn.myanimelist.net/images/anime/3/52133.jpg?s=eae1aba9fc65851acad0b750c9818b40",
"name": "Monogatari Series: Second Season",
"type": "TV",
"start_year": 2013
}
  • favorite manga comparison before and after changing
{
"mal_id": 81117,
"url": "https://myanimelist.net/manga/81117/Tokyo_Ghoul_re",
"image_url": "https://cdn.myanimelist.net/images/manga/3/145997.jpg?s=e95f2394cb7c6eac3873ae18e61e53c4",
"name": "Tokyo Ghoul:re"
}
{
"mal_id": 81117,
"url": "https://myanimelist.net/manga/81117/Tokyo_Ghoul_re",
"image_url": "https://cdn.myanimelist.net/images/manga/3/145997.jpg?s=e95f2394cb7c6eac3873ae18e61e53c4",
"name": "Tokyo Ghoul:re",
"type": "Manga",
"start_year": 2014
}
  • favorite character comparison before and after changing
{
"mal_id": 67065,
"url": "https://myanimelist.net/character/67065/Hachiman_Hikigaya",
"image_url": "https://cdn.myanimelist.net/images/characters/4/203555.jpg?s=b3ae7b289e6dd0290fa2d9a01ddf991c",
"name": "Hikigaya, Hachiman"
}
{
"mal_id": 67065,
"url": "https://myanimelist.net/character/67065/Hachiman_Hikigaya",
"image_url": "https://cdn.myanimelist.net/images/characters/4/203555.jpg?s=b3ae7b289e6dd0290fa2d9a01ddf991c",
"name": "Hikigaya, Hachiman",
"title_name": "Yahari Ore no Seishun Love Comedy wa Machigatteiru.",
"title_url": "https://myanimelist.net/anime/14813/Yahari_Ore_no_Seishun_Love_Comedy_wa_Machigatteiru",
"title_type": "anime",
"title_mal_id": 14813
}

trim titles of characters so it won't be multiline,
link for title will be absolute, fix proper type display
@irfan-dahir irfan-dahir self-requested a review July 10, 2020 16:32
@irfan-dahir
Copy link
Collaborator

This looks great. Thanks for the PR! Sorry it took me this long to get this reviewed.

Just a heads-up that I'll be modifying these things after merging this to keep it linear with the planned schema.

  1. start_year -> year

{
"mal_id": 67065,
"url": "https://myanimelist.net/character/67065/Hachiman_Hikigaya",
"image_url": "https://cdn.myanimelist.net/images/characters/4/203555.jpg?s=b3ae7b289e6dd0290fa2d9a01ddf991c",
"name": "Hikigaya, Hachiman",
"anime": {
"title_name": "Yahari Ore no Seishun Love Comedy wa Machigatteiru.",
"title_url": "https://myanimelist.net/anime/14813/Yahari_Ore_no_Seishun_Love_Comedy_wa_Machigatteiru",
"title_type": "anime",
"title_mal_id": 14813
}

to

{
	"mal_id": 67065,
	"url": "https://myanimelist.net/character/67065/Hachiman_Hikigaya",
	"image_url": "https://cdn.myanimelist.net/images/characters/4/203555.jpg?s=b3ae7b289e6dd0290fa2d9a01ddf991c",
	"name": "Hikigaya, Hachiman",
	"anime": {
		"mal_id": 14813,
		"title": "Yahari Ore no Seishun Love Comedy wa Machigatteiru.",
		"url": "https://myanimelist.net/anime/14813/Yahari_Ore_no_Seishun_Love_Comedy_wa_Machigatteiru",
		"type": "anime"
	}
}

@irfan-dahir irfan-dahir merged commit 9d1a282 into jikan-me:3.0.0 Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants