Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate request parameter reference "sfw" #522

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

tbkj98
Copy link
Contributor

@tbkj98 tbkj98 commented Mar 17, 2024

Removed duplicate request parameter reference "sfw" from the following requests

  1. GET "/anime"
  2. GET "/manga"
  3. GET "/schedules"

Removed duplicate request parameter reference "sfw"
@tbkj98 tbkj98 requested a review from a team as a code owner March 17, 2024 05:33
@pushrbx
Copy link
Collaborator

pushrbx commented Mar 20, 2024

Thanks for contributing. This should also be removed from the code too. The json file is generated from the comment sections in the code.

@tbkj98
Copy link
Contributor Author

tbkj98 commented Mar 23, 2024

I've removed the reference from Getter's comments.
Please review the PR again.

Copy link
Collaborator

@pushrbx pushrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I tried to generate the docs locally too, and it has generated the same output as your changes the api-docs.json file. Good job. 👍

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.45%. Comparing base (a415418) to head (5b656b4).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #522   +/-   ##
=========================================
  Coverage     57.45%   57.45%           
  Complexity     1352     1352           
=========================================
  Files           339      339           
  Lines          5209     5209           
=========================================
  Hits           2993     2993           
  Misses         2216     2216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pushrbx pushrbx merged commit 613db6c into jikan-me:master Mar 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants