fix(arch-tests): allow wire packages to depend on shared kernels #11061
+18
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
force-pushed
the
fix-hexagonal-archtests
branch
from
d7e3c51
to
3e9bf39
Compare
DamnClin
reviewed
Oct 8, 2024
| @@ -25,25 +24,25 @@ import org.springframework.stereotype.Controller; | |||
| class HexagonalArchTest { | |||
|
|
|||
| private static final String ROOT_PACKAGE = "{{packageName}}"; | |||
| private static final String GENERATION_SHARED_KERNEL_PACKAGES = ROOT_PACKAGE.concat(".shared.generation.."); | |||
| private static final String SHARED_PACKAGES = ROOT_PACKAGE.concat(".shared.."); | |||
There was a problem hiding this comment.
I think we should stick to annotation for that since it's usefull to have shared packages in other locations (especially for business shared packages)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.