Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jwt reflect and resource config to support jwt authentication type #59

Merged
merged 6 commits into from
Aug 21, 2022

Conversation

atomfrede
Copy link
Member

Native image can be build with jwt support and started. I got some errors when I tried to save a user (entity) but I seemed unrelated. Will open another issue for that.

@alina-yur especially for you

closes #48

@alina-yur
Copy link

this will be very helpful, thank you, @atomfrede!👏

@atomfrede
Copy link
Member Author

Looks like the threadpool for sending mails async is not working properly (non webflux). Going to investigate today. Besides that it looks quite well.

@atomfrede
Copy link
Member Author

Very strange, after I disabled async mail sending, the thymeleaf template can't be compile, because of an error with org.thymeleaf.exceptions.TemplateProcessingException: Exception evaluating SpringEL expression: "locale.language". Which is confusing as we have the same template with webflux and I can see there is a locale (which has of course a public getLanguage method).

@atomfrede
Copy link
Member Author

Seems I found a solution. Let me update the PR

@atomfrede
Copy link
Member Author

@mraible There seems to be an issue with macos ci. Will restart the failed builds, but everything works fine, now also with JWT 🎉

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS docker install is flaky. It should be ok to merge on install failures.
Samples are ok now, should be ok to merge if succeed.

@atomfrede
Copy link
Member Author

I have fixed remaining issues with webflux and reflect config. Macos build is working fine locally, so as @mshima said flaky environment. I would say let's merge it and create a new release.

@mshima mshima merged commit 82ada93 into jhipster:main Aug 21, 2022
@atomfrede
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jwt support
3 participants