Formative feedback #9
Conversation
| Return - nothing | ||
| """ | ||
|
|
||
| with open(TASK_FILE,"a", encoding="utf-8") as file: |
There was a problem hiding this comment.
Good code, but does two things in one commit. Split into two commits which means it's easier to unwind a specific set of changes (e.g. the add_tasks)
python/todo.py
Outdated
|
|
||
| def remove_task(index): | ||
| return | ||
|
|
There was a problem hiding this comment.
Try not to add random white space changes in a commit. Use git diff to see what will be changed and remove any unnecessary changes.
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
| def main(): |
There was a problem hiding this comment.
Random file changed, which has nothing to do with the commit.
| expected_list ="1. Item 1\n2. Item 2\n3. Item 3\n4. Item 4\n5. Item 5\n" | ||
| result = run(["python","todo.py","-l"], capture_output=True, check=True) | ||
| assert len(result.stdout) == 72 | ||
| #changed number from 50 to account for extra characters from adding "your task list" and r before every \n |
There was a problem hiding this comment.
comment is good. May need repeating below? Try leave space between # and comment and use correct capitalisation.
| Return: nothing | ||
| """ | ||
| if os.path.exists(TASK_FILE): | ||
| with open(TASK_FILE, "r", encoding="utf-8") as file: |
There was a problem hiding this comment.
Try and avoid nested with statement, especially on the same file. This could cause issues depending on the users setup.
| @@ -1,3 +1,6 @@ | |||
| """ | |||
| This script defines command-line arguements using the argparse module. | |||
There was a problem hiding this comment.
Nope. What does your programe do, not what the command line thing does.
| print(f"Task at index {index} removed.") | ||
| else: | ||
| print(f"Invalid task number: {index}. Please enter a number between 1 and {len(tasks)}.") | ||
| print(f"Invalid task number: {index}.Enter a number between 1") |
|
@TomCumber Comments above. Nice work. |
2 participants
Good work! Some nice little feature enhancements to help the user with (almost all) tests edited to match.
Keep doing the following:
To improve:
You forgot to edit something. However this will be the \r\n thing, so worth thinking how you'd deal with this in reality. You wouldn't lose any marks in the summative for this, but worth trying your code in Linux and seeing what the \r\n things means...