Formative feedback #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge temp branch into main
jhill1
commented
Apr 28, 2025
| import os | ||
|
|
||
| TASK_FILE = ".tasks.txt" | ||
| TASK_FILE = "todo_list.txt" |
jhill1
commented
Apr 28, 2025
python/todo.py
Outdated
| counter = 1 | ||
| output_string = "" | ||
|
|
||
| for i, task in enumerate(tasks): |
Owner
Author
There was a problem hiding this comment.
this could be done more efficiently, but is clear, which is the main thing.
jhill1
commented
Apr 28, 2025
python/todo.py
Outdated
| output_string = output_string + str(counter) + ". " + task | ||
| counter = counter + 1 | ||
| return output_string | ||
| file.close() |
Owner
Author
There was a problem hiding this comment.
don't need file.close() with with statement.
jhill1
commented
Apr 28, 2025
python/todo.py
Outdated
|
|
||
|
|
||
| """Appends a task to the end of the todo list file.""" | ||
| task="Item 6" |
Owner
Author
There was a problem hiding this comment.
This will only ever add "Item 6"...
jhill1
commented
Apr 28, 2025
python/todo.py
Outdated
| """Lists tasks within the task file""" | ||
| with open(TASK_FILE, "r") as file: | ||
| tasks = file.readlines() | ||
| tasks = file.readlines() |
Owner
Author
There was a problem hiding this comment.
You've also made changes to list tasks in a commit about add_task.
jhill1
commented
Apr 28, 2025
| @@ -1,3 +1,8 @@ | |||
| """ | |||
Owner
Author
There was a problem hiding this comment.
Make sure commit only add things in the message, not extra stuff
jhill1
commented
Apr 28, 2025
| def remove_task(index_str): | ||
| """Removes a task by index.""" | ||
| try: | ||
| index = int(index_str) # converts the string to an integer |
Owner
Author
There was a problem hiding this comment.
Don't need this if you'd left the int conversion in main.
Owner
Author
|
@ZorahRajput Comments above on the formative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice work!
Things you did well:
Where you could improve: