Formative feedback #5
Conversation
…from paste() so we need to use paste0()
…ts arent working now
…res but there are still errors
There was a problem hiding this comment.
This is an odd commit! Seems to have deleted the whole file and then replaced it with one extra line...Check what is to be commit with git diff and unwind if needed.
R/todo.R
Outdated
|
|
||
| tasks <- readLines(TASK_FILE) | ||
| } | ||
| print(tasks) |
There was a problem hiding this comment.
Try not to commit testing chnages
R/todo.R
Outdated
|
|
||
| #remember to change where .tasks is going | ||
| list_tasks <- function() { | ||
| counter <- 1 |
R/todo.R
Outdated
| tasks <- readLines(TASK_FILE) | ||
| for (item in tasks) { | ||
| output_string <- paste(output_string, counter, item) | ||
| output_string <- paste(output_string, counter, item, "\n" ) |
There was a problem hiding this comment.
This doesn't match the commit message...
| counter <- 1 | ||
| output_string <- "" | ||
| tasks <- readLines(TASK_FILE) | ||
| num_tasks <- length(tasks) |
There was a problem hiding this comment.
Good. Make the commit message something more like "List_tasks function complete and passing test", as the current message is vague
R/todo.R
Outdated
| remove_task <- function(index) { | ||
|
|
||
| tasks <- readLines(TASK_FILE) | ||
| task_removed <- tasks[-1] |
There was a problem hiding this comment.
Don't commit temporary stuff unless you're switching computers and need to push
R/todo.R
Outdated
|
|
||
|
|
||
| main <- function(args) { | ||
| #main <- function(args) { |
There was a problem hiding this comment.
Don't commit commented out code, even temporarily.
| tasks <- readLines(TASK_FILE) | ||
| if (index < length(tasks)) | ||
| tasks <- tasks[-index] | ||
| if (length(tasks) == 0) { |
| library(argparse) | ||
| }) | ||
|
|
||
|
|
There was a problem hiding this comment.
use # nolint to not lint a line (e.g. line 14). You should be able to return null or NA
|
@kkx504 COmmetns above and inline. Nice work! |
2 participants
Nice work! The code is easy to read and understandable with good comments.
To improve further:
Great stuff, well done.