-
Notifications
You must be signed in to change notification settings - Fork 25
Comments on formative #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhill1
wants to merge
28
commits into
jhill1:main
Choose a base branch
from
Nathaniel-Burford:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturning item 1 through 5
…efully pass the test
…code and also removed a comment from list_tasks
…acter(0)' git push q
… style'and 'length(output) not equal to 0.'
…orter and hopefully fixing the 'nchar(output) is not strictly less than 25.' failure
…urn()' to hopefully make sure it works again whie making output also below 25
…ack to fix the previouse test
…t if an error in tests occur
…causing an array in a test for main
… the entire code passing the test!
Owner
Author
|
@Nathaniel-Burford COmments above, click the wee speech bubble symbol for inline comments. Nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice work overall! Some nice bits of coding, e.g. the interactive() and some nice overall coding style. All tests pass and the code looks good and reads well.
Some fixes are:
1)
Shouldn't be needed unless the tests are broken...
Commenting is necessary at times
The commits are a bit haphazard, working on e thing, then another and moving back to the first. It makes it quite hard to unpick, e.g. if you wanted to revert a commit, but not lose other changes.
You've broken the the --help on the arparser...