Skip to content

Conversation

@jhill1
Copy link
Owner

@jhill1 jhill1 commented Apr 28, 2025

Nice work overall! Some nice bits of coding, e.g. the interactive() and some nice overall coding style. All tests pass and the code looks good and reads well.

Some fixes are:
1)

  if (!file.exists(TASK_FILE)) {
    #Listing expected output for test
    return("1. Item 1\n2. Item 2\n3. Item 3\n4. Item 4\n5. Item 5")
  }

Shouldn't be needed unless the tests are broken...

  1. Commenting is necessary at times

  2. The commits are a bit haphazard, working on e thing, then another and moving back to the first. It makes it quite hard to unpick, e.g. if you wanted to revert a commit, but not lose other changes.

  3. You've broken the the --help on the arparser...

…code and also removed a comment from list_tasks
…orter and hopefully fixing the 'nchar(output) is not strictly less than 25.' failure
…urn()' to hopefully make sure it works again whie making output also below 25
@jhill1
Copy link
Owner Author

jhill1 commented Apr 28, 2025

@Nathaniel-Burford COmments above, click the wee speech bubble symbol for inline comments. Nice work.

@jhill1 jhill1 closed this Apr 28, 2025
@jhill1 jhill1 reopened this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants