Formative feedback #11
Conversation
python/todo.py
Outdated
| Return - nothing | ||
| """ | ||
|
|
||
| with open(TASK_FILE, "a") as f: #append ensures text is always inserted at the end of the file |
There was a problem hiding this comment.
Good; comment should probably be more a # Note: append to add task to end of list
| f.write(task + "\n") | ||
|
|
||
| def list_tasks(): | ||
| """Function: list_tasks |
There was a problem hiding this comment.
Try not to change two things in one commit. You've edited the add_task and list_tasks on same commit, which makes it harder to unwind
python/todo.py
Outdated
| return "" | ||
|
|
||
| with open(TASK_FILE, "r") as f: | ||
| with open(TASK_FILE, "r") as f: |
There was a problem hiding this comment.
Avoid adding whitespace in a commit. Use git diff to see what is being changed
python/todo.py
Outdated
| read = f.readlines() | ||
|
|
||
| return "".join(f"{i+1}. {task}" for i, task in enumerate(read)) #combines and numbers tasks | ||
| return "\n".join(f"{i+1}. {task.strip()}" for i, task in enumerate(read)).strip() #combines and numbers tasks |
There was a problem hiding this comment.
rstrip is probably the better function here as you only want whitespac stripping from right
| with open(TASK_FILE, "a") as f: #text is inserted at the end of the file | ||
|
|
||
| with open(TASK_FILE, "a") as f: | ||
| #insert text at the end of the file |
There was a problem hiding this comment.
indent comment to match code
| """ | ||
|
|
||
| with open(TASK_FILE, "a") as f: | ||
| with open(TASK_FILE, "a", encoding="utf-8") as f: |
There was a problem hiding this comment.
As previous; try and group commits into logical units so unwinding them is easier, i.e. do all the comment lint tasks, then the encoding, then the imports, etc, etc
|
@TobyD785 Really nice work. Feedback above |
2 participants
Excellent work! All tests pass cleanly. Code is well written and clear.
Things done well:
To improve