Formative feedback

[jhill1]

Nice work; clear code and passes tests (with caveats).

What you did well:

• clear, easily followed code
• some nice feature enhancements that were followed through to the tests
• tests all pass (I think!)

What could be improved:

• The assessment should have been done in the python directory, rather than move to the main directory; it pollutes the git history
• There are multiple chnages in a git commit, rather than an atomic change
• Your tests fail on linux due to the \r\n thing. Worth thinking about how to handle that in future. You can test on linux too...
• Think about adding comments in places which are non-obvious, e.g. the rstrip.

[jhill1]

Don't commit random lines. use git diff to see what will be chnaged

[jhill1]

Avoid two functions in one commit. You may want to roll back add_task, but keep list_tasks. You can't do this easily with two functions in one commit.

[jhill1]

Might need a commetn above this for why the rstrip.

[jhill1]

As above; don't add random line in a commit unless they are needed.

[jhill1]

@RoryAlexander1 COmments on the formative above.