More descriptive error messages #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sam-Robin
commented
Jul 24, 2024
Comment on lines
+680
to
+684
| it "raises Discard::RecordNotUndiscarded" do | ||
| expect(post).to receive(:do_before_undiscard) { abort_callback } | ||
| expect { | ||
| post.undiscard! | ||
| }.to raise_error(Discard::RecordNotUndiscarded) | ||
| }.to raise_error(Discard::RecordNotUndiscarded, "Failed to undiscard the record") |
There was a problem hiding this comment.
I also noticed this test had the wrong name
jarednorman
requested changes
Jul 25, 2024
lib/discard/model.rb
Outdated
| raise ::Discard::RecordNotUndiscarded.new(undiscarded_fail_message, self) | ||
| end | ||
|
|
||
| def disacrded_fail_message |
There was a problem hiding this comment.
There's a typo in this method name.
| @@ -677,11 +677,11 @@ def abort_callback | |||
| end | |||
|
|
|||
| describe '#undiscard!' do | |||
| it "raises Discard::RecordNotDiscarded" do | |||
| it "raises Discard::RecordNotUndiscarded" do | |||
|
Looks good! I will merge this once I've figured out what's going on with CI. |
|
Thank you! Have a lovely day/afternoon/evening 😄 |
jhawthorn
approved these changes
Sep 10, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with the discard gem I noticed that you can't discard already discarded records. There wasn't any mention of this in the docs and the error message wasn't very helpful. It cost me some time debugging.
Hopefully this saves others a bit of time :)