Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added large size elephpants #58

Closed
wants to merge 18 commits into from
Closed

Added large size elephpants #58

wants to merge 18 commits into from

Conversation

wimg
Copy link
Contributor

@wimg wimg commented Oct 1, 2020

I added the large (jumbo) size elephpants. They are in the db in a field "size" (free text, who knows what we get in the future).

Fixes #7

@wimg wimg closed this Oct 1, 2020
@wimg
Copy link
Contributor Author

wimg commented Oct 1, 2020

Will squash first ;-)

@doppynl
Copy link
Contributor

doppynl commented Oct 1, 2020

Might be better to show the size when it is not "normal" and give all existing elephpants a size of "normal" or "small". Implementation would be a bit cleaner.
Currently it shows the size when it is "large" and hides it in all other cases.

@pgrimaud
Copy link
Contributor

pgrimaud commented Oct 2, 2020

Will you recreate a PR @wimg?

@wimg
Copy link
Contributor Author

wimg commented Oct 2, 2020

I will, but currently reinstalling my dev system after a hardware problem. Give me a few days.

@wimg
Copy link
Contributor Author

wimg commented Nov 21, 2020

@doppynl Re-reading your comment... isn't what you're saying contradictory ? Or am I misreading ?

@doppynl
Copy link
Contributor

doppynl commented Nov 24, 2020

I think my comment wasn't very clear. I'll try to rephrase it.

The implementation in the pull request checks the size and if it is "large" it will display the size. In other cases it will not show the size.
What would happen if a new size was added? Like a "Tiny" for instance.

To me the implementation would be more clean if:

  • All elephpants get a size configured. Existing ones would get "small" for instance. (although "normal" would also be a fine choice).
  • When displaying size, only display it when it is not "small" and use the size property to display instead of hardcoded "large".

This would also make it easier to make additions in the future. Like new sizes, or filtering based on size.

@wimg
Copy link
Contributor Author

wimg commented Nov 30, 2020

Made a new pull request #86 to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add big ones
3 participants