Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPStan and Eddie Elephpants #197

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

JonPurvis
Copy link
Contributor

@JonPurvis JonPurvis commented Jan 29, 2024

This PR adds 2 new Elephpants to the website:

I'll keep an eye out for some better photos, but I'd quite like to get these on the site soon!

@JonPurvis JonPurvis changed the title Add PHPStan Elephpant Add PHPStan and Eddie Elephpants Jan 29, 2024
@JonPurvis
Copy link
Contributor Author

@teiling88 @jgrossi

Does this look okay to you?

@jgrossi
Copy link
Owner

jgrossi commented Jan 30, 2024

yep looks good to me! thanks for contributing

@JonPurvis
Copy link
Contributor Author

You're welcome!

@JonPurvis
Copy link
Contributor Author

@jgrossi Whilst you're here, would you be open to accepting #174?

The Sylius Elephpant reached its funding goal this morning so it reminded me the PR existed 😆

@teiling88 teiling88 merged commit 381b393 into jgrossi:master Jan 30, 2024
1 check passed
@teiling88
Copy link
Collaborator

Hey @JonPurvis,
I didn't find the time for testing this mr. I think in the next week it will be merged or commented :-)

@JonPurvis
Copy link
Contributor Author

No problem @teiling88, PHPStan isn't realised yet and Eddie won't be given out until the conference happens in Mid February so it's not like anyone has them to add to their Herd yet, all good! 👍

@teiling88
Copy link
Collaborator

My comment was about #174 :-)

This one is merged and will be deployed the next days :-)

@JonPurvis
Copy link
Contributor Author

My bad 😆

@JonPurvis
Copy link
Contributor Author

@teiling88 Hey, do you know when this PR is likely to be deployed? Lots of people now have Eddie (the conference finished today).

@jgrossi
Copy link
Owner

jgrossi commented Feb 17, 2024

hey! just deployed! all good ;-)

@JonPurvis
Copy link
Contributor Author

Awesome, thanks @jgrossi - I'm going to try and source a different picture of Eddie, one without the PHPUK logo in the top left of the picture!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants