Skip to content

Fix iOS first recording returning null due to premature session termination #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix iOS first recording returning null due to premature session termination #192

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
912f222
Initial plan
Copilot Oct 25, 2025
589a670
Fix iOS audio recording null return on first recording
Copilot Oct 25, 2025
f334fd5
Refactor: Extract cleanup logic to reduce code duplication
Copilot Oct 25, 2025
bc592dc
Fix redundant event unsubscription in cleanup
Copilot Oct 25, 2025
f53acc6
Improve comment clarity for cleanup call
Copilot Oct 25, 2025
86d5ccc
Merge branch 'main' into copilot/fix-ios-stopasync-null-object
jfversluis Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/Plugin.Maui.Audio/AudioRecorder/AudioRecorder.macios.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ partial class AudioRecorder : IAudioRecorder
public AudioRecorder(AudioRecorderOptions audioRecorderOptions)
{
this.audioRecorderOptions = audioRecorderOptions;

ActiveSessionHelper.FinishSession(audioRecorderOptions);
}


Expand All @@ -42,6 +40,9 @@ public Task StartAsync(string filePath, AudioRecorderOptions? options = null)
audioRecorderOptions = options;
}

// Clean up any previous recorder instance
CleanupRecorderResources();

ActiveSessionHelper.InitializeSession(audioRecorderOptions);

var url = NSUrl.FromFilename(filePath);
Expand Down Expand Up @@ -86,7 +87,12 @@ destinationFilePath is null ||

ActiveSessionHelper.FinishSession(audioRecorderOptions);

return new FileAudioSource(destinationFilePath);
var audioSource = new FileAudioSource(destinationFilePath);

// Clean up resources (event unsubscribed on line 86)
CleanupRecorderResources(unsubscribeEvent: false);

return audioSource;
}

static readonly NSObject[] keys = new NSObject[]
Expand All @@ -105,6 +111,22 @@ void Recorder_FinishedRecording(object? sender, AVStatusEventArgs e)
finishedRecordingCompletionSource?.SetResult(true);
}

void CleanupRecorderResources(bool unsubscribeEvent = true)
{
if (recorder is not null)
{
if (unsubscribeEvent)
{
recorder.FinishedRecording -= Recorder_FinishedRecording;
}
recorder.Dispose();
recorder = null;
}

destinationFilePath = null;
finishedRecordingCompletionSource = null;
}

AudioFormatType SharedEncodingToiOSEncoding(Encoding type, bool throwIfNotSupported)
{
return type switch
Expand Down