added comments, fixes #2 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks a lot. Can you add a test to reproduce this issue? |
|
@jfromaniello yes sure, I will take a look at that :) |
rauberdaniel
changed the title
replace normalize function to only use 3 replace rules instead of 6
|
@jfromaniello Okay so I did a major rewrite now because 6 replace calls were feeling a little much… So I replaced the whole functionality with 3 replace calls. I think it would be great to also be able to pass options (e.g. |
|
This is very well done! Thank you, I published it as |
|
@jfromaniello thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #2