Add patterns to OIDC identity mapping #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation to 'username' attribute to ensure 'scope' attribute is also Don't set 'scope' attribute unless it's not empty string Update documentation to include the same
danielmkn
reviewed
Oct 31, 2024
| Optional: | ||
|
|
||
| - `audience` (String) Sets of (space separated) the JFrog services to which the mapping applies. Default value is `*@*`, which applies to all services. | ||
| - `expires_in` (Number) Token expiry time in seconds. Default value is 60. | ||
| - `groups_pattern` (String) Provide a pattern which is used to map OIDC groups to Artifactory groups. |
There was a problem hiding this comment.
Should you add an example here? It should be inside of {{}}
There was a problem hiding this comment.
I added example in the section above.
danielmkn
reviewed
Oct 31, 2024
| - `username` (String) User name of the OIDC user. Not applicable when `scope` is set to `applied-permissions/groups`. Must be set when `scope` is set to `applied-permissions/roles`. | ||
| - `username_pattern` (String) Provide a pattern which is used to map OIDC user to Artifactory user. |
There was a problem hiding this comment.
Should you add an example here? It should be inside of {{}}
There was a problem hiding this comment.
Same, look at the TF example
danielmkn
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145