Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform_saml_settings.certificate should be sensitive #135

Closed
nbaju1 opened this issue Oct 7, 2024 · 1 comment · Fixed by #136
Closed

platform_saml_settings.certificate should be sensitive #135

nbaju1 opened this issue Oct 7, 2024 · 1 comment · Fixed by #136
Assignees
@alexhung
Labels
bug Something isn't working

Comments

@nbaju1
Copy link

nbaju1 commented Oct 7, 2024

Currently, the full SAML certificate is printed in the plan output.
Should be marked as sensitive in the resource schema.
@alexhung
Copy link
Member

alexhung commented Oct 7, 2024

@nbaju1 Thanks for the report! You're 100%. I forgot to mark this attribute as sensitive.

@alexhung alexhung added the bug Something isn't working label Oct 7, 2024
@alexhung alexhung mentioned this issue Oct 7, 2024
Merged
alexhung added a commit that referenced this issue Oct 7, 2024
@alexhung
Merge pull request #136 from jfrog/GH-135-fix-saml-settings-certifica…
dd4f710 
…te-attribute-not-marked-as-sensitive

Set saml_settings 'certificate' attribute as sensitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexhung alexhung

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set saml_settings 'certificate' attribute as sensitive jfrog/terraform-provider-platform
2 participants
@alexhung @nbaju1