Skip to content

Commit

Permalink
Merge pull request #136 from jfrog/GH-135-fix-saml-settings-certifica…
Browse files Browse the repository at this point in the history
…te-attribute-not-marked-as-sensitive

Set saml_settings 'certificate' attribute as sensitive
  • Loading branch information
alexhung authored Oct 7, 2024
2 parents 35e878d + df03449 commit dd4f710
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 1.13.1 (October 8, 2024). Tested on Artifactory 7.90.13 with Terraform 1.9.7 and OpenTofu 1.8.3

BUG FIXES:

* resource/platform_saml_settings: Fix `certificate` attribute not being set as 'sensitive' so its value is redacted in CLI output/log. Issue: [#135](https://github.com/jfrog/terraform-provider-platform/issues/135) PR: [#136](https://github.com/jfrog/terraform-provider-platform/pull/136)

## 1.13.0 (October 4, 2024). Tested on Artifactory 7.90.13 with Terraform 1.9.7 and OpenTofu 1.8.3

NOTES:
Expand Down
3 changes: 2 additions & 1 deletion pkg/platform/resource_saml_settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ var samlSettingsSchemaV0 = map[string]schema.Attribute{
MarkdownDescription: "When set, SAML integration is enabled and users may be authenticated via a SAML server. Default value is `true`.",
},
"certificate": schema.StringAttribute{
Required: true,
Required: true,
Sensitive: true,
Validators: []validator.String{
stringvalidator.LengthAtLeast(1),
},
Expand Down

0 comments on commit dd4f710

Please sign in to comment.