Go - Support projects with embed files #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Nov 7, 2023
src/main/treeDataProviders/dependenciesTree/dependenciesRoot/goTree.ts
Outdated
Show resolved
Hide resolved
Or-Geva
added
bug
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Projects in Go that involve embedded files encounter an error when attempting to construct the dependency tree.
The issue place in how we convert all "replace" labels in the go.mod file from relative to absolute paths before gathering dependencies for all projects. During this process, we exclude any files that do not have a ".go" extension. Consequently, this exclusion results in missing embedded files, leading to an error when using the "go list" command.
As a solution, we restrict the exclusion to specific, well-known folders that are safe to omit, such as "testdata" or ".git."
Fix #372