Improve login error message #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or-Geva
added
improvement
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Nov 5, 2023
| ) { | ||
| return false; | ||
| this.deleteCredentialsFromMemory(); | ||
| return TestConnectionStatus.FailedBadCredentials; |
There was a problem hiding this comment.
How can you determine that this is a Bad Credential (401) error rather than:
- A permissions problem (403)
- An inactive server - I'm not sure if it is relevant anymore but worth checking
- Any other error, like 5xx
Take a look at testComponentPermission. I recommend returning the precise status from this function.
Comment on lines
+184
to
+186
| if (!(await this.testConnectionHealth())) { | ||
| this.deleteCredentialsFromMemory(); | ||
| return TestConnectionStatus.FailedServerNotFound; |
There was a problem hiding this comment.
Suggested change
| if (!(await this.testConnectionHealth())) { | |
| this.deleteCredentialsFromMemory(); | |
| return TestConnectionStatus.FailedServerNotFound; |
And what if we get 401 in the ping? This request seems redundant, because testComponentPermission already handle the response parsing.
| return LoginProgressStatus.FailedSaveCredentials; | ||
| case TestConnectionStatus.FailedServerNotFound: | ||
| return LoginProgressStatus.FailedServerNotFound; |
There was a problem hiding this comment.
Let's add another status for permission denied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Fixes: #430