Yarn - Fix incorrect impact graph #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
force-pushed
the
yarnImpactedPath
branch
from
baa290f to
eaea074
Compare
Or-Geva
added
bug
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Sep 27, 2023
src/main/treeDataProviders/dependenciesTree/dependenciesTreeNode.ts
Outdated
Show resolved
Hide resolved
src/main/treeDataProviders/dependenciesTree/dependenciesRoot/rootTree.ts
Outdated
Show resolved
Hide resolved
src/main/treeDataProviders/dependenciesTree/dependenciesRoot/rootTree.ts
Outdated
Show resolved
Hide resolved
src/main/treeDataProviders/dependenciesTree/dependenciesRoot/rootTree.ts
Outdated
Show resolved
Hide resolved
src/main/treeDataProviders/dependenciesTree/dependenciesRoot/rootTree.ts
Outdated
Show resolved
Hide resolved
yahavi
requested changes
Sep 27, 2023
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Prior to this PR, there was an issue with the way Yarn calculated the impact graph. The problem intruduced from using the 'yarn list' output. The 'yarn list' output did not accurately represent the project's dependencies as it removed duplicate leaves and flattened the tree structure.
In order to resolve this issue, this PR changes the following:
Instead of constructing the entire dependency tree, we now compute only a partial tree. This partial tree specifically represents the paths from the project's root to the vulnerable dependencies only. This modification eliminates the need to calculate the entire tree, which not only reduces memory consumption but also aligns with our goal of displaying only paths to vulnerable dependencies.
Rather than relying on
yarn list, we have switched to usingyarn whywhich provides the correct path to a specific dependency. This involves gathering all vulnerable dependencies and utilizing 'yarn why' to map out the path of each dependency from the root.