Fix CR comments

jfrog · Nov 7, 2023 · 41b8e4c · 41b8e4c
1 parent 378affc
commit 41b8e4c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/src/main/treeDataProviders/dependenciesTree/dependenciesRoot/goTree.ts b/src/main/treeDataProviders/dependenciesTree/dependenciesRoot/goTree.ts
@@ -91,7 +91,7 @@ export class GoTreeNode extends RootNode {
             directDependenciesGeneralInfos.push(new GeneralInfo(nameVersionTuple[0], nameVersionTuple[1], ['None'], '', PackageType.Go));
         }
 
-        //Filter out go min version that is written in go mod e.g. go@v1.19
+        // Filter out go min version that is written in go mod e.g. go@v1.19
         directDependenciesGeneralInfos = directDependenciesGeneralInfos.filter(generalInfo => !generalInfo.artifactId.startsWith('go@'));
 
         // Create a set of packages that are actually in use in the project

diff --git a/src/main/utils/goUtils.ts b/src/main/utils/goUtils.ts
@@ -211,7 +211,7 @@ export class GoUtils {
         logManager: LogManager,
         executeCmdFunction: (goModPath: string, sourceDir: string, goModAbsDir: string) => void
     ) {
-        logManager.logMessage('copy go workspace from' + sourceDir + ', to' + targetDir, 'DEBUG');
+        logManager.logMessage('Copy go workspace from' + sourceDir + ', to' + targetDir, 'DEBUG');
         walkdir.find(sourceDir, { follow_symlinks: false, sync: true }, function(curPath: string, stat: fs.Stats) {
             let destPath: string = path.resolve(targetDir, path.relative(sourceDir, curPath));
 
@@ -220,7 +220,7 @@ export class GoUtils {
                     this.ignore(curPath);
                     return;
                 }
-                if (!(curPath === sourceDir)) {
+                if (curPath !== sourceDir) {
                     // Skip subdirectories with go.mod files.
                     // These directories are different Go projects and their go files should not be in the root project.
                     let files: string[] = fs.readdirSync(curPath).filter(fn => fn === 'go.mod');
@@ -236,11 +236,7 @@ export class GoUtils {
                 return;
             }
 
-            if (curPath.endsWith('_test.go')) {
-                return;
-            }
-
-            logManager.logMessage('copying ' + curPath + ' to ' + destPath, 'DEBUG');
+            logManager.logMessage('Copying ' + curPath + ' to ' + destPath, 'DEBUG');
             fs.copySync(curPath, destPath);
 
             // The root go.mod file is copied and relative path in "replace" are resolved to absolute paths.

diff --git a/src/test/tests/goUtils.test.ts b/src/test/tests/goUtils.test.ts
@@ -238,12 +238,10 @@ describe('Go Utils Tests', async () => {
             const sourceDir: string = path.join(tmpDir, 'prepareProjectWorkspace');
             const targetDir: string = path.join(tmpDir, 'tmpDir');
 
-
             GoUtils.prepareProjectWorkspace(sourceDir, targetDir, '', logManager, () => {
                 return;
             });
 
-
             assert.isFalse(fs.existsSync(targetDir), 'The target directory should not exist since all files should be excluded');
         });
     });