Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet - Allow to set allowInsecureConnections package source attribute #2758

Merged
merged 22 commits into from
Nov 21, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Nov 14, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Allows the user to set allowInsecureConnections in NuGet config file.

  <packageSources>
    <add key="JFrogCli" value="%s" protocolVersion="%s" **allowInsecureConnections**="%v"/>
  </packageSources>

The latest .NET 6 release introduces changes to NuGet that now restrict the use of insecure connections for package sources unless a specific flag is enabled.

This update resolves the failing tests by adding the required flag for cases where it is necessary. This flag is primarily intended for testing purposes to allow use with local sources and should not be enabled in production environments.

Dependencies

This PR depends on the following PRs:

@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Nov 14, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@EyalDelarea EyalDelarea changed the base branch from v2 to dev November 14, 2024 09:39
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@EyalDelarea EyalDelarea changed the title Nuget - Add allowInsecureConnections for package sources flag & Fix tests Nuget - Add allowInsecureConnections for package sources flag Nov 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@EyalDelarea EyalDelarea changed the title Nuget - Add allowInsecureConnections for package sources flag Nuget - Add allowInsecureConnections for package sources Nov 14, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review November 14, 2024 12:38
@EyalDelarea EyalDelarea changed the title Nuget - Add allowInsecureConnections for package sources Nuget - Allow to set allowInsecureConnections package source attribute Nov 14, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 21, 2024
@EyalDelarea EyalDelarea merged commit 18be369 into jfrog:dev Nov 21, 2024
62 of 63 checks passed
oshratZairi pushed a commit to oshratZairi/jfrog-cli that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants