Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods config #2708

Closed
wants to merge 2 commits into from
Closed

Cocoapods config #2708

wants to merge 2 commits into from

Conversation

barv-jfrog
Copy link
Contributor

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@barv-jfrog barv-jfrog changed the title cocoapods-config Cocoapods config Sep 30, 2024
@eyalbe4 eyalbe4 self-requested a review October 15, 2024 04:20
@@ -1815,6 +1816,9 @@ var commandFlags = map[string][]string{
url, user, password, accessToken, sshPassphrase, sshKeyPath, serverId, refs, glcRepo, glcDryRun,
glcQuiet, InsecureTls, retries, retryWaitTime,
},
CocoapodsConfig: {
global, serverIdResolve, serverIdDeploy, repoResolveReleases, repoResolveSnapshots, repoDeploySnapshots, repoDeployReleases,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serverIdDeploy shouldn't be added for package managers that do not deploy packages to Artifactory.
In addition, the following options should be removed (they are all maven specific):

  • repoResolveReleases
  • repoResolveSnapshots
  • repoDeploySnapshots

The only options that are needed are the below (see NugetConfig above as a reference):

  • global
  • serverIdResolve
  • repoResolve

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants