Add Shellcheck action and fix issues, also adds npm build script tests #2208

sverdlov93 · 2023-09-14T12:16:49Z

All tests have passed. If this feature is not already covered by the tests, new tests have been added.
The pull request is targeting the dev branch.
The code has been validated to compile successfully by running go vet ./....
The code has been formatted properly using go fmt ./....

Signed-off-by: Michael Sverdlov <[email protected]>

…-version

Signed-off-by: Michael Sverdlov <[email protected]>

…-version # Conflicts: # go.mod # go.sum

Signed-off-by: Michael Sverdlov <[email protected]>

…-version

Signed-off-by: Michael Sverdlov <[email protected]>

yahavi

Looks good.
Please consider combining multiple strings into a single one when possible to make them easier for the random reader.

.github/workflows/scriptTests.yml

build/deb_rpm/v2-jf/build-scripts/pack.sh

build/deb_rpm/v2-jf/build-scripts/rpm-install.sh

build/deb_rpm/v2/build-scripts/pack.sh

build/npm/v2-jf/package-lock.json

build/npm/v2/package-lock.json

Co-authored-by: Yahav Itzhak <[email protected]>

Signed-off-by: Michael Sverdlov <[email protected]>

.github/workflows/scriptTests.yml

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 added 12 commits September 5, 2023 20:43

copy dir

86700bc

Signed-off-by: Michael Sverdlov <[email protected]>

copy dir

6bb231f

Signed-off-by: Michael Sverdlov <[email protected]>

Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into anlyzer…

f4a6e78

…-version

Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into anlyzer…

18097da

…-version

Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into anlyzer…

c06f602

…-version

fix build script

ac0598e

Signed-off-by: Michael Sverdlov <[email protected]>

fix build script

9d8d6b0

Signed-off-by: Michael Sverdlov <[email protected]>

Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into anlyzer…

aab974a

…-version # Conflicts: # go.mod # go.sum

fix build script

db0937e

Signed-off-by: Michael Sverdlov <[email protected]>

fix build script

9a5ea33

Signed-off-by: Michael Sverdlov <[email protected]>

fix build script

17881f9

Signed-off-by: Michael Sverdlov <[email protected]>

fix build script

2f16607

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 14, 2023 12:16 — with GitHub Actions Failure

sverdlov93 requested a review from yahavi September 14, 2023 12:16

Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into anlyzer…

76aaf7a

…-version

sverdlov93 had a problem deploying to frogbot September 14, 2023 12:17 — with GitHub Actions Failure

fix build script

b7d3887

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 14, 2023 12:43 — with GitHub Actions Failure

fix build script

beac533

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 14, 2023 13:06 — with GitHub Actions Failure

fix build script

088cd21

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 14, 2023 13:07 — with GitHub Actions Failure

Merge branch 'dev' into anlyzer-version

bc05a54

sverdlov93 had a problem deploying to frogbot September 21, 2023 08:57 — with GitHub Actions Failure

fix build script

d67d3cc

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 21, 2023 08:59 — with GitHub Actions Failure

fix build script

e0f725a

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 21, 2023 09:09 — with GitHub Actions Failure

fix build script

58dbe50

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 21, 2023 09:22 — with GitHub Actions Failure

fix build script

f5f947f

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 21, 2023 12:14 — with GitHub Actions Failure

fix build script

2c835f5

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 21, 2023 12:20 — with GitHub Actions Failure

fix build script

e1c223c

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 21, 2023 12:20 — with GitHub Actions Failure

fix build script

97bd4d2

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 21, 2023 12:21 — with GitHub Actions Failure

yahavi requested changes Sep 24, 2023

View reviewed changes

Update .github/workflows/scriptTests.yml

a2acfd8

Co-authored-by: Yahav Itzhak <[email protected]>

sverdlov93 had a problem deploying to frogbot September 26, 2023 09:16 — with GitHub Actions Failure

Update .github/workflows/scriptTests.yml

645cc8f

Co-authored-by: Yahav Itzhak <[email protected]>

sverdlov93 had a problem deploying to frogbot September 26, 2023 09:16 — with GitHub Actions Failure

Update .github/workflows/scriptTests.yml

0329d80

Co-authored-by: Yahav Itzhak <[email protected]>

sverdlov93 had a problem deploying to frogbot September 26, 2023 09:17 — with GitHub Actions Failure

Update build/deb_rpm/v2-jf/build-scripts/pack.sh

29ca950

Co-authored-by: Yahav Itzhak <[email protected]>

sverdlov93 had a problem deploying to frogbot September 26, 2023 09:17 — with GitHub Actions Failure

fix build script

8777656

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 26, 2023 09:26 — with GitHub Actions Failure

sverdlov93 requested a review from yahavi September 26, 2023 09:26

fix build script

099c3b2

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 26, 2023 10:44 — with GitHub Actions Failure

yahavi reviewed Sep 26, 2023

View reviewed changes

.github/workflows/scriptTests.yml Show resolved Hide resolved

fix build script

eacbd5f

Signed-off-by: Michael Sverdlov <[email protected]>

sverdlov93 had a problem deploying to frogbot September 26, 2023 10:50 — with GitHub Actions Failure

Merge branch 'dev' into anlyzer-version

9d2f938

sverdlov93 added the safe to test Approve running integration tests on a pull request label Sep 26, 2023

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 26, 2023

sverdlov93 had a problem deploying to frogbot September 26, 2023 10:55 — with GitHub Actions Failure

sverdlov93 merged commit b04accc into jfrog:dev Sep 26, 2023
57 of 66 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Shellcheck action and fix issues, also adds npm build script tests #2208

Add Shellcheck action and fix issues, also adds npm build script tests #2208

sverdlov93 commented Sep 14, 2023

yahavi left a comment

Add Shellcheck action and fix issues, also adds npm build script tests #2208

Add Shellcheck action and fix issues, also adds npm build script tests #2208

Conversation

sverdlov93 commented Sep 14, 2023

yahavi left a comment

Choose a reason for hiding this comment