Filter out non-applicable violations if requested bu policy #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded the new parsed violations results to ApplicabilityScanManager.
…ew parsed violations results to IacScanManager.
…new parsed violations results to SastScanManager.
…e new parsed violations results to SecretScanManager.
…ded relevant logs
…methods for hte new struct
…o jas-violations-support
…canner cannot incur violations
…y commented at this point)
…o delete comments in results.go)
…rseCommandResults related to jas violations
…esults) + changed the names for Sca parsing methods
…all relevant references
…all relevant references
…man/jfrog-cli-security into skip-not-applicable-cves
…man/jfrog-cli-security into skip-not-applicable-cves # Conflicts: # go.mod # go.sum # utils/results/common.go
7 tasks
…man/jfrog-cli-security into skip-not-applicable-cves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....This Pr introduces an additional filtering to found violations:
If a violation is non-applicable AND the policy that initiated the violation is set to "skip non applicable" - the violation will not appear in the final results (audit, scan, frogbot)
This PR includes changes from this PR #241 that needs to be merged prior to this one
This PR depends on: jfrog/jfrog-client-go#1052