Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control the depth of the pnpm dependency tree #202

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 9, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

PNPM improvements

  • Add option to control the depth of the pnpm dependency tree
  • Show pnpm install cmd log If error occur

@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Oct 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 9, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 10, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@attiasas attiasas changed the title Show pnpm install cmd log If error occur Add option to control the depth of the pnpm dependency tree Oct 13, 2024
Copy link
Contributor

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flag name + dotnet version

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 14, 2024
Copy link
Contributor

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a question, suggestion, and test addition request

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

github-actions bot commented Dec 1, 2024

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/cli 0.00% (ø)
github.com/jfrog/jfrog-cli-security/cli/docs 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/audit/sca/pnpm 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/cli/docs/flags.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/cli/scancommands.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/audit/sca/pnpm/pnpm.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/auditbasicparams.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/commands/audit/sca/pnpm/pnpm_test.go

@attiasas attiasas changed the title Add option to control the depth of the pnpm dependency tree Control the depth of the pnpm dependency tree Dec 1, 2024
expectedUniqueDeps []string
expectedTree *xrayUtils.GraphNode
}{
// {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove dead code?

Copy link
Contributor

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove dead code and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants