Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle args with spaces fail the command execution #830

Closed
wants to merge 10 commits into from

Conversation

keeganjm-bsc
Copy link

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@keeganjm-bsc
Copy link
Author

This PR is related to jfrog/jfrog-cli#921 and jfrog/jfrog-cli#2029 is needed to pass in multiple tags with space. For example:
-Dkarate.options="--tags=@smoke --tags=~@regression"

This command fails when being passed as the gradle command using jfrog cli like so
'jfrog rt gradle clean assemble myTest -Dkarate.options="--tags=@smoke --tags=~@regression"'

Currently the gradleCmd is not taking the complete value of -Dkarate.options and is interpreting the white space in the command as a break in the cmd line argument for -Dkarate.options and is then looking at --tags as a commandline argument. Here is an example of how it is appearing in the logs.

'jfrog rt gradle clean assemble myTest -Dkarate.options=--tags=@smoke --tags=~@regression'

Note the space after '@smoke'. This is what appears to be causing us issues. As the error coming into our logs is saying --tags is not a command line argument.

@keeganjm-bsc
Copy link
Author

@eyalbe4 is there anything I can do to move this forward to get reviewed? This PR is blocking another PR from being able to get tested and reviewed. If there is anything I can do from my end please let me know. Thanks!

@keeganjm-bsc
Copy link
Author

@eyalbe4 Any update on this?

@keeganjm-bsc
Copy link
Author

@eyalbe4 Is there anything I can do to get this PR moved forward? Please let me know

@keeganjm-bsc
Copy link
Author

@yahavi Is there anything we can do to get this PR moved forward?

@keeganjm-bsc
Copy link
Author

@yahavi @eyalbe4 @RobiNino please review this PR.

@eyalbe4 eyalbe4 temporarily deployed to frogbot July 19, 2023 14:42 — with GitHub Actions Inactive
@eyalbe4 eyalbe4 added the bug Something isn't working label Jul 19, 2023
@eyalbe4 eyalbe4 changed the title Bugfix - Gradle args with spaces Gradle args with spaces fail the command execution Jul 19, 2023
eyalbe4
eyalbe4 previously approved these changes Jul 19, 2023
@github-actions
Copy link
Contributor

@eyalbe4 eyalbe4 dismissed their stale review July 19, 2023 15:28

I noticed that there's already an ongoing discussion related to this fix in jfrog/jfrog-cli#2029. So I'm holding off the approval of this PR till that discussion is finalized.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Dec 20, 2023

I believe this PR can be closed, since #1072 already addresses this issue.
Let us know if you think otherwise, and thanks for creating this @keeganjm-bsc!

@eyalbe4 eyalbe4 closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants