-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle args with spaces fail the command execution #830
Conversation
keeganjm-bsc
commented
Jun 19, 2023
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
This PR is related to jfrog/jfrog-cli#921 and jfrog/jfrog-cli#2029 is needed to pass in multiple tags with space. For example: This command fails when being passed as the gradle command using jfrog cli like so Currently the gradleCmd is not taking the complete value of -Dkarate.options and is interpreting the white space in the command as a break in the cmd line argument for -Dkarate.options and is then looking at --tags as a commandline argument. Here is an example of how it is appearing in the logs. 'jfrog rt gradle clean assemble myTest -Dkarate.options=--tags=@smoke --tags=~@regression' Note the space after '@smoke'. This is what appears to be causing us issues. As the error coming into our logs is saying --tags is not a command line argument. |
@eyalbe4 is there anything I can do to move this forward to get reviewed? This PR is blocking another PR from being able to get tested and reviewed. If there is anything I can do from my end please let me know. Thanks! |
@eyalbe4 Any update on this? |
@eyalbe4 Is there anything I can do to get this PR moved forward? Please let me know |
@yahavi Is there anything we can do to get this PR moved forward? |
I noticed that there's already an ongoing discussion related to this fix in jfrog/jfrog-cli#2029. So I'm holding off the approval of this PR till that discussion is finalized.
I believe this PR can be closed, since #1072 already addresses this issue. |