Fix for #2874 release-bundle-create is not working with projects #1356
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bhanurp
commented
Feb 24, 2025
•
bhanurp
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
4 tasks
EyalDelarea
requested changes
Feb 25, 2025
| @@ -7,31 +7,39 @@ import ( | |||
|
|
|||
| func TestCreateSpecFromBuildNameAndNumber(t *testing.T) { | |||
| t.Run("Valid Inputs", func(t *testing.T) { | |||
| spec, err := CreateSpecFromBuildNameAndNumber("Common-builds", "1.2.0") | |||
| spec, err := CreateSpecFromBuildNameAndNumber("Common-builds", "1.2.0", "test") | |||
There was a problem hiding this comment.
Let's extract the logic of projects key into a different test function
or we should change the name to TestCreateSpecFromBuildNameAndNumberAndProjectKey, which seems a bit long :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.