Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pipenv graph invalid JSON #290

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

attiasas
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix (Also add extend logs for debugging)

For some projects pipenv graph --json produce not valid json (added \n) prevents Unmarshal

Error: 3 [Error] target '/tmp/jfrog.cli.temp.-1734955979-676905686 [pipenv]' errors:
Failed to build dependency tree: failed while building 'pipenv' dependency tree: failed to parse pipenv graph --json output: invalid character '\n' in string literal

image

@attiasas attiasas added the bug Something isn't working label Dec 24, 2024
Copy link

github-actions bot commented Jan 6, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


@EyalDelarea EyalDelarea changed the title Pipenv graph produce not valid json Fix Pipenv graph invalid JSON Jan 6, 2025
@EyalDelarea EyalDelarea merged commit f25981f into jfrog:dev Jan 6, 2025
16 checks passed
@attiasas attiasas mentioned this pull request Jan 7, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants