Even Better TS #307
Merged
Even Better TS #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, these only show up in my ide's search sometimes. Not sure why, but here's the annotations.
eslint-plugin-jsdoc automatically removes these. Fair enough for 99% of cases, but `unicorn/no-object-as-default-parameter` _correctly_ points out that default objects need to be spread. This adds back the jsdoc docs for this specific case.
lishaduck
force-pushed
the
even-better-ts
branch
from
28031d5
to
d1f1898
Compare
jfmengels
reviewed
Nov 10, 2024
jfmengels
reviewed
Nov 10, 2024
I started with uppercasing the `R`. Then, I replace `Err` with `Failure` so it doesn't get mixed up with native JS errors. I did the same with `Ok` and `Success`, so that the constructors line up. I tried uppercasing the constructors as well, to make it more elmish.* However, Eslint triggers `new-cap`, so I skipped that one and kept the Task terminology. Also, because objects are really inconvenient, I moved it to a folder and used evil barrel exports. * I tried to come up with a Fable pun, but I couldn't think of one.
Way back a long time ago in jfmengels#186 (comment), @jfmengels asked me to write some comments. I also updated the workflows to align with recent changes to our test workflow in jfmengels#288.
Addresses @jfmengels's feedback from jfmengels#187 (comment). Co-authored-by: Jeroen Engels <[email protected]>
lishaduck
force-pushed
the
even-better-ts
branch
from
d1f1898
to
7497bd9
Compare
|
Hit rate limits. Will try again later. |
jfmengels
approved these changes
Nov 10, 2024
|
Thank you, these are nice changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #302 (and #186 and #187).