More TS #301
Merged
More TS #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lishaduck
force-pushed
the
more-ts
branch
2 times, most recently
from
1fd229c
to
bfeebc9
Compare
Working around microsoft/TypeScript#26382, which will likely never get solved.
This seems to be the way you're supposed to write overloads, but it does feel wrong.
The inferred type is more specific.
Closed
jfmengels
reviewed
Nov 4, 2024
| /** | ||
| * @param {Template} template | ||
| * @param {string} commit | ||
| */ |
There was a problem hiding this comment.
Should this not a return type annotation? (Same of other functions in this file)?
There was a problem hiding this comment.
They should, but I used the IDE inferer to get started, which skips them, unfortunately, and I didn't realize it until I was done.
TS infers them though, so I think it can be left for a follow-up.
jfmengels
reviewed
Nov 4, 2024
Comment on lines
+362
to
+363
| * @param {string} dest | ||
| * @param {string} elmModulePath |
There was a problem hiding this comment.
I think this would be more accurate:
* @param {Path} dest
* @param {Path} elmModulePath
Same for elmBinary below and other places in this file.
This is just a shorthand for all of the strict rules the TS team feels are ergonomic. I disabled `useUnknownInCatch` variables for now, though.
tsconfig changes can affect types, which affect typed linting results.
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Woohoo! This is a great step forward! |
Merged
lishaduck
added a commit
to lishaduck/node-elm-review
that referenced
this pull request
Nov 6, 2024
Address review comments from jfmengels#301.
lishaduck
added a commit
to lishaduck/node-elm-review
that referenced
this pull request
Nov 6, 2024
Address review comments from jfmengels#301.
lishaduck
added a commit
to lishaduck/node-elm-review
that referenced
this pull request
Nov 6, 2024
Address review comments from jfmengels#301.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly, steadily, yet always onward, pushing forward, toward the goal.
In other words, more types.
Or rather, better types, as this was mostly fixing mistakes.(Nope, I ended up just finishing #125)Resolves #125.