fix: errors caught by promise rules

jfmengels · Nov 6, 2024 · fb9e058 · fb9e058
1 parent 6ca8dfb
commit fb9e058
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -142,8 +142,6 @@ module.exports = {
     '@typescript-eslint/no-misused-promises': 'off',
     '@typescript-eslint/no-floating-promises': 'off',
     '@typescript-eslint/prefer-promise-reject-errors': 'off',
-    'promise/catch-or-return': 'off',
-    'promise/always-return': 'off',
 
     // TODO(@lishaduck): Security issues that should eventually get fixed.
     'security/detect-object-injection': 'off',

diff --git a/lib/build.js b/lib/build.js
@@ -584,12 +584,13 @@ async function buildElmParser(options, reviewElmJson) {
     // Needed when the user has `"type": "module"` in their package.json.
     // Our output is CommonJS.
     // TODO(@lishaduck): Switch to a .cjs file instead.
-    FS.mkdirp(options.generatedCodePackageJson()).then(async () => {
+    async () => {
+      await FS.mkdirp(options.generatedCodePackageJson());
       await FS.writeFile(
         path.join(options.generatedCodePackageJson(), 'package.json'),
         '{"type":"commonjs"}'
       );
-    })
+    }
   ]);
 
   await compileElmProject(

diff --git a/lib/parse-elm-worker.js b/lib/parse-elm-worker.js
@@ -22,10 +22,9 @@ if (parentPort) {
  * @returns {void}
  */
 function subscribe(parentPort) {
-  parentPort.on('message', (queueItem) => {
-    workerParseElm(queueItem).then((result) => {
-      parentPort.postMessage(result);
-    });
+  parentPort.on('message', async (queueItem) => {
+    const result = await workerParseElm(queueItem);
+    parentPort.postMessage(result);
   });
 }