Introduce Self type #179
Open
Introduce Self type #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Google thinks these are the release dates for the relevant Python versions:
I'd be OK dropping 3.8 support - 2019 was a while ago! But dropping 3.10 might be a bridge too far. Dunno. |
This change removes Python 3.8, 3.9 and 3.10 support. This reverts commit 6952e9a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #177, I stubbed out typing
Selfparameters, but I setSelf = Anyto maintain Python 3.8, 3.9 and 3.10 support. This PR closes the loop and usestyping.Selffor that annotation. This yields a slight improvement in type safety.This change does remove Python 3.8, 3.9 and 3.10 support.