Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup (for #2) #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Cleanup (for #2) #13

wants to merge 6 commits into from

Conversation

jferragut
Copy link
Owner

@jferragut jferragut commented Nov 12, 2019

Addresses the following issues related to #2

  • cleaned up some files that were causing issue with boilerplate
  • modified user endpoint to show example of firebase firestore for data storage
  • added model.py to show how we inherit from a base class that we create to represent our data
  • added example of .env and key.json which are required for the firebase endpoint
  • added dependencies to pipfile
  • adjusted scripts in pipfile for zeit instead of flask local dev for a more accurate dev server
  • updated git ignore to include the key.json file so you don't accidentally push your google credentials to repo

@vercel
Copy link

vercel bot commented Nov 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/jferragut/flask-microservices-boilerplate/49rv1xm0k
🌍 Preview: https://flask-microservices-boilerplate-git-cleanup.jferragut.now.sh

@jferragut
Copy link
Owner Author

@alesanchezr when you have a moment, can you please review this PR

@jferragut jferragut changed the title Cleanup Cleanup (for #2) Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant