Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(AbstractNamedBuilderFactory): extract method #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(AbstractNamedBuilderFactory): extract method #65

wants to merge 1 commit into from

Conversation

saurabhjdas786
Copy link

  • buildWhereClause() is a long method hence extracted the "appending of params to the where clause" computation from the function.
  • Introduced new method appendParamsToWhereClause() that appends the params to tailOfSql.
  • Improves readability of buildWhereClause().

@saurabhjdas786
refactor(AbstractNamedBuilderFactory): extract method
3715686 
- buildWhereClause() is a long method hence extracted the
  "appending of params to the where clause" computation
  from the function.
- Improves readability of buildWhereClause().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@saurabhjdas786