Fixes #12323 - AsyncMiddleManServlet response flushing. #12542
+128
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed `ProxyWriter.chunks` locking. * Made `writeProxyResponseContent()` protected so it can be overridden to flush the response content. * Added test case. Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
iiliev2
reviewed
Nov 15, 2024
| @@ -610,7 +612,10 @@ public boolean offer(ByteBuffer content, Callback callback) | |||
| { | |||
| if (_log.isDebugEnabled()) | |||
| _log.debug("{} proxying content to downstream: {} bytes {}", getRequestId(clientRequest), content.remaining(), callback); | |||
| return chunks.offer(new Chunk(content, callback)); | |||
| try (AutoLock ignored = lock.lock()) | |||
There was a problem hiding this comment.
What is the benefit of this solution, rather than just using something like ConcurrentLinkedDeque for the chunks ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProxyWriter.chunkslocking.writeProxyResponseContent()protected so it can be overridden to flush the response content.