Skip to content

VC-42286-add-total-%-cov #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

VC-42286-add-total-%-cov #673

merged 1 commit into from
Jul 15, 2025

Conversation

mladen-rusev-cyberark
Copy link
Collaborator

  • add line to print total coverage in test-unit

* add line to print total coverage in test-unit
@mladen-rusev-cyberark mladen-rusev-cyberark self-assigned this Jun 24, 2025
@mladen-rusev-cyberark mladen-rusev-cyberark marked this pull request as draft June 25, 2025 08:34
@mladen-rusev-cyberark mladen-rusev-cyberark marked this pull request as ready for review July 15, 2025 09:08
Copy link
Contributor

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Looks great, thanks!

@@ -11,4 +11,5 @@ test-unit: | $(NEEDS_GO) $(NEEDS_GOTESTSUM) $(ARTIFACTS) $(NEEDS_ETCD) $(NEEDS_K
-- \
-ldflags $(go_preflight_ldflags)

$(GO) tool cover -func=$(ARTIFACTS)/filtered.cov
Copy link
Contributor

@SgtCoDFish SgtCoDFish Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the total being printed in test output:

total:	(statements)	47.2%

@SgtCoDFish SgtCoDFish merged commit 342c0e3 into master Jul 15, 2025
2 checks passed
@SgtCoDFish SgtCoDFish deleted the VC-42286-add-total-%-cov branch July 15, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants